OSDN Git Service

chelsio/chtls: Re-add dependencies on CHELSIO_T4 to fix modular CHELSIO_T4
authorGeert Uytterhoeven <geert+renesas@glider.be>
Tue, 15 Sep 2020 09:35:51 +0000 (11:35 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 15 Sep 2020 22:58:52 +0000 (15:58 -0700)
commite859536dac30aa891a01462eef6e12168c6e8f29
tree0f3e127caab0e8b56cbcfe0f40f017e9dc03b746
parentb18af883dce6c1a1f87ca2b3b64985160157391b
chelsio/chtls: Re-add dependencies on CHELSIO_T4 to fix modular CHELSIO_T4

As CHELSIO_INLINE_CRYPTO is bool, and CHELSIO_T4 is tristate, the
dependency of CHELSIO_INLINE_CRYPTO on CHELSIO_T4 is not sufficient to
protect CRYPTO_DEV_CHELSIO_TLS and CHELSIO_IPSEC_INLINE.  The latter two
are also tristate, hence if CHELSIO_T4=n, they cannot be builtin, as
that would lead to link failures like:

    drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c:259: undefined reference to `cxgb4_port_viid'

and

    drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c:752: undefined reference to `cxgb4_reclaim_completed_tx'

Fix this by re-adding dependencies on CHELSIO_T4 to tristate symbols.
The dependency of CHELSIO_INLINE_CRYPTO on CHELSIO_T4 is kept to avoid
asking the user.

Fixes: 6bd860ac1c2a0ec2 ("chelsio/chtls: CHELSIO_INLINE_CRYPTO should depend on CHELSIO_T4")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/chelsio/inline_crypto/Kconfig