OSDN Git Service

[PDB] Fix linking of function symbols and local variables.
authorZachary Turner <zturner@google.com>
Tue, 8 Aug 2017 18:34:44 +0000 (18:34 +0000)
committerZachary Turner <zturner@google.com>
Tue, 8 Aug 2017 18:34:44 +0000 (18:34 +0000)
commite87e5c313d6d32043232a95d1c963b613b083652
tree2cde2dfe53e6ebb70dacc499b8ac5042287bf6b1
parentf3855901e0f1404a8bae20e4c788281d66cecf29
[PDB] Fix linking of function symbols and local variables.

The compiler outputs PROC32_ID symbols into the object files
for functions, and these symbols have an embedded type index
which, when copied to the PDB, refer to the IPI stream.  However,
the symbols themselves are also converted into regular symbols
(e.g. S_GPROC32_ID -> S_GPROC32), and type indices in the regular
symbol records refer to the TPI stream.  So this patch applies
two fixes to function records.
  1. It converts ID symbols to the proper non-ID record type.
  2. After remapping the type index from the object file's index
     space to the PDB file/IPI stream's index space, it then
     remaps that index to the TPI stream's index space by.

Besides functions, during the remapping process we were also
discarding symbol record types which we did not recognize.
In particular, we were discarding S_BPREL32 records, which is
what MSVC uses to describe local variables on the stack.  So
this patch fixes that as well by copying them to the PDB.

Differential Revision: https://reviews.llvm.org/D36426

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@310394 91177308-0d34-0410-b5e6-96231b3b80d8
include/llvm/DebugInfo/CodeView/TypeDeserializer.h
include/llvm/DebugInfo/CodeView/TypeIndexDiscovery.h
lib/DebugInfo/CodeView/TypeIndexDiscovery.cpp
tools/llvm-pdbutil/DumpOutputStyle.cpp
tools/llvm-pdbutil/MinimalSymbolDumper.cpp
tools/llvm-pdbutil/MinimalSymbolDumper.h
unittests/DebugInfo/CodeView/TypeIndexDiscoveryTest.cpp