OSDN Git Service

USB: usb-skeleton.c: fix compilation error and restored kref_put on fail in skel_open
authorConstantine Shulyupin <const@MakeLinux.com>
Wed, 10 Oct 2012 14:14:00 +0000 (16:14 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 24 Oct 2012 21:40:50 +0000 (14:40 -0700)
commite8cebb9cde3716800219ea8473306d431e83154b
tree6577ad2ba289d7d62c44208220d4b69b51ab185d
parent801f00633568ed6d5eebef5ef10d8b5661379f2c
USB: usb-skeleton.c: fix compilation error and restored kref_put on fail in skel_open

Fixing compilaton error.
Incrementing usage counter only on successful execution of skel_open.
Removing redundant locking

Some last changes in function skel_open and finally commit
52a7499 Revert "USB: usb-skeleton.c: fix open/disconnect race"
introduced a bug in function skel_open, which this patch fixes.

Changes since v2:
- refactoring
- Removing redundant mutex synchronization.

Changes since v1:
- Fixed accordingly feedback of Oliver Neukum oneukum@suse.de: also need to drop the lock.

Signed-off-by: Constantine Shulyupin <const@MakeLinux.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/usb-skeleton.c