OSDN Git Service

block: fix leaking page ref on truncated direct io
authorKeith Busch <kbusch@kernel.org>
Tue, 12 Jul 2022 15:32:56 +0000 (08:32 -0700)
committerJens Axboe <axboe@kernel.dk>
Wed, 3 Aug 2022 03:08:54 +0000 (21:08 -0600)
commite97424fd44727b4a5ecb124a49f575fed6086999
tree8cf90aab52270f2e71cb3b961c3c32d51d66ebf1
parent34cdb8c825f28a5c91c5336a80967533da57da74
block: fix leaking page ref on truncated direct io

The size being added to a bio from an iov is aligned to a block size
after the pages were gotten. If the new aligned size truncates the last
page, its reference was being leaked. Ensure all pages that were not
added to the bio have their reference released.

Since this essentially requires doing the same that bio_put_pages(), and
there was only one caller for that function, this patch makes the
put_page() loop common for everyone.

Fixes: b1a000d3b8ec5 ("block: relax direct io memory alignment")
Reported-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Keith Busch <kbusch@kernel.org>
Link: https://lore.kernel.org/r/20220712153256.2202024-3-kbusch@fb.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/bio.c