OSDN Git Service

drm/msm/dpu: Remove commit and its uses in dpu_crtc_set_crc_source()
authorNathan Chancellor <nathan@kernel.org>
Tue, 26 Oct 2021 14:24:36 +0000 (07:24 -0700)
committerRob Clark <robdclark@chromium.org>
Tue, 26 Oct 2021 16:29:54 +0000 (09:29 -0700)
commite9afd45788d223bfd562dd062e43208e958683e7
tree55bdbbb377ac976717de857dadc726344147c529
parent00326bfa4e6363e4b0b8b019ecd2556fdda5ad1c
drm/msm/dpu: Remove commit and its uses in dpu_crtc_set_crc_source()

Clang warns:

drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c:162:6: error: variable 'commit' is uninitialized when used here [-Werror,-Wuninitialized]
        if (commit)
            ^~~~~~
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c:106:32: note: initialize the variable 'commit' to silence this warning
        struct drm_crtc_commit *commit;
                                      ^
                                       = NULL
1 error generated.

The assignment and use of commit in the main body of
dpu_crtc_set_crc_source() were removed from v1 to v2 but the call to
drm_crtc_commit_put() at the end was not. Do that now so there is no
more warning.

Fixes: 78d9b458cc21 ("drm/msm/dpu: Add CRC support for DPU")
Link: https://github.com/ClangBuiltLinux/linux/issues/1493
Reported-by: "kernelci.org bot" <bot@kernelci.org>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20211026142435.3606413-1-nathan@kernel.org
Signed-off-by: Rob Clark <robdclark@chromium.org>
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c