OSDN Git Service

ACPI/IORT: Fix iort_get_platform_device_domain() uninitialized pointer value
authorLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Thu, 29 Nov 2018 09:55:59 +0000 (09:55 +0000)
committerCatalin Marinas <catalin.marinas@arm.com>
Fri, 30 Nov 2018 17:28:39 +0000 (17:28 +0000)
commitea2412dc21cc790335d319181dddc43682aef164
tree1ca875b940d0dc6187939022020616272e6b5e79
parent874bfc6e5422d2421f7e4d5ea318d30e91679dfe
ACPI/IORT: Fix iort_get_platform_device_domain() uninitialized pointer value

Running the Clang static analyzer on IORT code detected the following
error:

Logic error: Branch condition evaluates to a garbage value

in

iort_get_platform_device_domain()

If the named component associated with a given device has no IORT
mappings, iort_get_platform_device_domain() exits its MSI mapping loop
with msi_parent pointer containing garbage, which can lead to erroneous
code path execution.

Initialize the msi_parent pointer, fixing the bug.

Fixes: d4f54a186667 ("ACPI: platform: setup MSI domain for ACPI based
platform device")
Reported-by: Patrick Bellasi <patrick.bellasi@arm.com>
Reviewed-by: Hanjun Guo <hanjun.guo@linaro.org>
Acked-by: Will Deacon <will.deacon@arm.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
drivers/acpi/arm64/iort.c