OSDN Git Service

platform/x86: dell-wmi-sysman: Cleanup sysman_init() error-exit handling
authorHans de Goede <hdegoede@redhat.com>
Sun, 21 Mar 2021 11:58:59 +0000 (12:58 +0100)
committerHans de Goede <hdegoede@redhat.com>
Sun, 21 Mar 2021 16:41:24 +0000 (17:41 +0100)
commiteaa1dcc79694674494620ee62098b937ef758df8
tree58c64716ac46c93c676a55d64ea2ecb3073af123
parentf4c4e9ad1523a32a78f5caf68f1b346a30035481
platform/x86: dell-wmi-sysman: Cleanup sysman_init() error-exit handling

Cleanup sysman_init() error-exit handling:

1. There is no need for the fail_reset_bios and fail_authentication_kset
   eror-exit cases, these can be handled by release_attributes_data()

2. Rename all the labels from fail_what_failed, to err_what_to_cleanup
   this is the usual way to name these and avoids the need to rename
   them when extra steps are added.

Fixes: e8a60aa7404b ("platform/x86: Introduce support for Systems Management Driver over WMI for Dell Systems")
Cc: Divya Bharathi <Divya_Bharathi@dell.com>
Cc: Mario Limonciello <mario.limonciello@dell.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20210321115901.35072-6-hdegoede@redhat.com
drivers/platform/x86/dell/dell-wmi-sysman/sysman.c