OSDN Git Service

fs: sysfs: don't pass count == 0 to bin file readers
authorVladimir Zapolskiy <vz@mleia.com>
Thu, 21 May 2015 21:21:16 +0000 (00:21 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 1 Jun 2015 01:17:17 +0000 (10:17 +0900)
commiteaa5cd926345f86e9df1eb6b0490da539f5ce7d0
treea1048947c68ae9bae7c93a3848387fcd557b5839
parent9ba8af66432cb8e82553f2e273eb11db0cec7d2d
fs: sysfs: don't pass count == 0 to bin file readers

If count == 0 bytes are requested by a reader, sysfs_kf_bin_read()
deliberately returns 0 without passing a potentially harmful value to
some externally defined underlying battr->read() function.

However in case of (pos == size && count) the next clause always sets
count to 0 and this value is handed over to battr->read().

The change intends to make obsolete (and remove later) a redundant
sanity check in battr->read(), if it is present, or add more
protection to struct bin_attribute users, who does not care about
input arguments.

Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/sysfs/file.c