OSDN Git Service

scsi: core: sysfs: Fix setting device state to SDEV_RUNNING
authorMike Christie <michael.christie@oracle.com>
Sat, 20 Nov 2021 16:49:17 +0000 (10:49 -0600)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 23 Nov 2021 03:18:54 +0000 (22:18 -0500)
commiteb97545d6264b341b06ba7603f52ff6c0b2af6ea
tree59da219368dbc7870cc32080c8610c2c39678945
parente0a2c28da11e2c2b963fc01d50acbf03045ac732
scsi: core: sysfs: Fix setting device state to SDEV_RUNNING

This fixes an issue added in commit 4edd8cd4e86d ("scsi: core: sysfs: Fix
hang when device state is set via sysfs") where if userspace is requesting
to set the device state to SDEV_RUNNING when the state is already
SDEV_RUNNING, we return -EINVAL instead of count. The commmit above set ret
to count for this case, when it should have set it to 0.

Link: https://lore.kernel.org/r/20211120164917.4924-1-michael.christie@oracle.com
Fixes: 4edd8cd4e86d ("scsi: core: sysfs: Fix hang when device state is set via sysfs")
Reviewed-by: Lee Duncan <lduncan@suse.com>
Signed-off-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/scsi_sysfs.c