OSDN Git Service

usb: gadget: f_ncm: remove check for NULL skb_tx_data in timer function
authorMaciej Żenczykowski <maze@google.com>
Thu, 1 Jul 2021 11:48:31 +0000 (04:48 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 21 Jul 2021 08:04:19 +0000 (10:04 +0200)
commitec017d6b60f8aa400987fe95cd839e9ba5dda41d
tree255b7db453d000e084ceddcf1a0e5220e5714225
parentcf4e2e880bde13af103d229be261e8f80c37921f
usb: gadget: f_ncm: remove check for NULL skb_tx_data in timer function

This condition is already checked for in ncm_wrap_ntb(),
except that that check is done with eth_dev->lock held
(it is grabbed by eth_start_xmit).

It's best to not be reaching into ncm struct without locks held.

Cc: Brooke Basile <brookebasile@gmail.com>
Cc: "Bryan O'Donoghue" <bryan.odonoghue@linaro.org>
Cc: Felipe Balbi <balbi@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Lorenzo Colitti <lorenzo@google.com>
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Link: https://lore.kernel.org/r/20210701114834.884597-3-zenczykowski@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/function/f_ncm.c