OSDN Git Service

ARM: dts: n900: remove mmc1 card detect gpio
authorMerlijn Wajer <merlijn@wizzup.org>
Tue, 30 Jun 2020 18:47:40 +0000 (11:47 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 30 Jun 2020 19:06:51 +0000 (12:06 -0700)
commited3e98e919aaaa47e9d9f8a40c3f6f4a22577842
tree474ae86f98b7d5aaa8cef895986996f5b00c528f
parentc463bb2a8f8d7d97aa414bf7714fc77e9d3b10df
ARM: dts: n900: remove mmc1 card detect gpio

Instead, expose the key via the input framework, as SW_MACHINE_COVER

The chip-detect GPIO is actually detecting if the cover is closed.
Technically it's possible to use the SD card with open cover. The
only downside is risk of battery falling out and user being able
to physically remove the card.

The behaviour of SD card not being available when the device is
open is unexpected and creates more problems than it solves. There
is a high chance, that more people accidentally break their rootfs
by opening the case without physically removing the card.

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Merlijn Wajer <merlijn@wizzup.org>
Link: https://lore.kernel.org/r/20200612125402.18393-3-merlijn@wizzup.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
arch/arm/boot/dts/omap3-n900.dts