OSDN Git Service

net: usb: r8152: use irqsave() in USB's complete callback
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Wed, 20 Jun 2018 19:31:20 +0000 (21:31 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 22 Jun 2018 04:57:45 +0000 (13:57 +0900)
commited7aa30e861510043f602b39f460c90aba792776
tree8ccbfd2f6106cfb551bba191cf09124a4efb3b16
parentba49fed8bbaebe6cc1fba0ac57789894be7121ed
net: usb: r8152: use irqsave() in USB's complete callback

The USB completion callback does not disable interrupts while acquiring
the lock. We want to remove the local_irq_disable() invocation from
__usb_hcd_giveback_urb() and therefore it is required for the callback
handler to disable the interrupts while acquiring the lock.
The callback may be invoked either in IRQ or BH context depending on the
USB host controller.
Use the _irqsave() variant of the locking primitives.

Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/r8152.c