OSDN Git Service

drm/msm/mdp5: Fix mdp5_cfg_init error return
authorJeffrey Hugo <jeffrey.l.hugo@gmail.com>
Tue, 21 May 2019 15:00:30 +0000 (08:00 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Jan 2020 09:21:44 +0000 (10:21 +0100)
commitedfcab71278d5f2949e5dccc092ba7486508594f
treee26d0856c2c50e6e3d5d95f0a8039b4e7573fb97
parentfb5c1d13a7ec4c9609379640dbde96e90deb0509
drm/msm/mdp5: Fix mdp5_cfg_init error return

[ Upstream commit fc19cbb785d7bbd1a1af26229b5240a3ab332744 ]

If mdp5_cfg_init fails because of an unknown major version, a null pointer
dereference occurs.  This is because the caller of init expects error
pointers, but init returns NULL on error.  Fix this by returning the
expected values on error.

Fixes: 2e362e1772b8 (drm/msm/mdp5: introduce mdp5_cfg module)
Signed-off-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Rob Clark <robdclark@chromium.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.c