OSDN Git Service

Change regexp engine's ccondissect/crevdissect routines to perform DFA
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 1 Feb 2010 02:45:29 +0000 (02:45 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 1 Feb 2010 02:45:29 +0000 (02:45 +0000)
commitee3a81f0a03d0da128689df92a84a24a337645ec
treefe61304097c96b921df66dd2aba113ce734a22f9
parentc85c941470efc44494fd7a5f426ee85fc65c268c
Change regexp engine's ccondissect/crevdissect routines to perform DFA
matching before recursing instead of after.  The DFA match eliminates
unworkable midpoint choices a lot faster than the recursive check, in most
cases, so doing it first can speed things up; particularly in pathological
cases such as recently exhibited by Michael Glaesemann.

In addition, apply some cosmetic changes that were applied upstream (in the
Tcl project) at the same time, in order to sync with upstream version 1.15
of regexec.c.

Upstream apparently intends to backpatch this, so I will too.  The
pathological behavior could be unpleasant if encountered in the field,
which seems to justify any risk of introducing new bugs.

Tom Lane, reviewed by Donal K. Fellows of Tcl project
src/backend/regex/regexec.c