OSDN Git Service

netdevsim: don't overwrite read only ethtool parms
authorFilip Pokryvka <fpokryvk@redhat.com>
Fri, 10 Dec 2021 17:50:32 +0000 (18:50 +0100)
committerJakub Kicinski <kuba@kernel.org>
Sat, 11 Dec 2021 05:23:05 +0000 (21:23 -0800)
commitee60e626d536da4c710b3634afe68fe7c6d69b59
tree75a306c280d1fc067f64cdd6a59c82c044a79eb3
parent94f2a444f28a649926c410eb9a38afb13a83ebe0
netdevsim: don't overwrite read only ethtool parms

Ethtool ring feature has _max_pending attributes read-only.
Set only read-write attributes in nsim_set_ringparam.

This patch is useful, if netdevsim device is set-up using NetworkManager,
because NetworkManager sends 0 as MAX values, as it is pointless to
retrieve them in extra call, because they should be read-only. Then,
the device is left in incosistent state (value > MAX).

Fixes: a7fc6db099b5 ("netdevsim: support ethtool ring and coalesce settings")
Signed-off-by: Filip Pokryvka <fpokryvk@redhat.com>
Link: https://lore.kernel.org/r/20211210175032.411872-1-fpokryvk@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/netdevsim/ethtool.c