OSDN Git Service

scsi: lpfc: size cpu map by last cpu id set
authorJames Smart <jsmart2021@gmail.com>
Thu, 21 Nov 2019 17:55:56 +0000 (09:55 -0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 22 Nov 2019 01:49:50 +0000 (20:49 -0500)
commiteede4970fb6c29f2056d7d016a3764c90e9d8a65
treefa89560199df9329090780bec49e12583854b71d
parent75d886a9938432364ef1051f4f3d22d6d9788d8c
scsi: lpfc: size cpu map by last cpu id set

Currently the lpfc driver sizes its cpu_map array based on
num_possible_cpus(). However, that can be a value that is less than the
highest cpu id bit that is set. As such, if a thread runs on a cpu with a
larger cpu id, or for_each_possible_cpu() is used, the driver could index
off the end of the array and return garbage or GPF.

The driver maintains its own internal copy of the "num_possible" cpu value
and sizes arrays by it.

Fix by setting the driver's value to the value of the last cpu id bit set
in the possible_mask - plus 1. Thus cpu_map will be sized to allow access
by any cpu id possible.

Link: https://lore.kernel.org/r/20191121175556.18953-1-jsmart2021@gmail.com
Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/lpfc/lpfc_init.c