OSDN Git Service

ISDN: eicon: switch to use native bitmaps
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 18 Jul 2017 15:49:26 +0000 (18:49 +0300)
committerDavid S. Miller <davem@davemloft.net>
Wed, 19 Jul 2017 23:24:59 +0000 (16:24 -0700)
commiteeef1713cacdb3cf657c9830e5a4c61e7f35c60a
treeee1490ad4b120c595e9686e54a5fd9441016afab
parent9b17010da57ae1a5d0a28c62f5e15abbce35edb0
ISDN: eicon: switch to use native bitmaps

Two arrays are clearly bit maps, so, make that explicit by converting to
bitmap API and remove custom helpers.

Note sig_ind() uses out of boundary bit to (looks like) protect against
potential bitmap_empty() checks for the same bitmap.

This patch removes that since:
1) that didn't guarantee atomicity anyway;
2) the first operation inside the for-loop is set bit in the bitmap
   (which effectively makes it non-empty);
3) group_optimization() doesn't utilize possible emptiness of the bitmap
   in question.

Thus, if there is a protection needed it should be implemented properly.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/isdn/hardware/eicon/divacapi.h
drivers/isdn/hardware/eicon/message.c