OSDN Git Service

batman-adv: protect tt_local_entry from concurrent delete events
authorMarek Lindner <mareklindner@neomailbox.ch>
Wed, 17 Jun 2015 12:01:36 +0000 (20:01 +0800)
committerAntonio Quartulli <antonio@meshcoding.com>
Tue, 4 Aug 2015 22:31:47 +0000 (00:31 +0200)
commitef72706a0543d0c3a5ab29bd6378fdfb368118d9
tree5a485c9fbb22698333415e7804510ff108d21e20
parent354136bcc3c4f40a2813bba8f57ca5267d812d15
batman-adv: protect tt_local_entry from concurrent delete events

The tt_local_entry deletion performed in batadv_tt_local_remove() was neither
protecting against simultaneous deletes nor checking whether the element was
still part of the list before calling hlist_del_rcu().

Replacing the hlist_del_rcu() call with batadv_hash_remove() provides adequate
protection via hash spinlocks as well as an is-element-still-in-hash check to
avoid 'blind' hash removal.

Fixes: 068ee6e204e1 ("batman-adv: roaming handling mechanism redesign")
Reported-by: alfonsname@web.de
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
net/batman-adv/translation-table.c