OSDN Git Service

QEMUSizedBuffer: only free qsb that qemu_bufopen allocated
authorYang Hongyang <yanghy@cn.fujitsu.com>
Fri, 19 Dec 2014 03:38:05 +0000 (11:38 +0800)
committerAmit Shah <amit.shah@redhat.com>
Fri, 16 Jan 2015 07:36:17 +0000 (13:06 +0530)
commitf018d8cd2123f495300935d5019931abbee4e5d9
tree6884c7b70c7121bc48349ceebba7126c7e73aaf7
parent1b826f277814dd9496fe3cc71cbe6ab7b203cadf
QEMUSizedBuffer: only free qsb that qemu_bufopen allocated

Only free qsb that qemu_bufopen allocated, and also allow
qemu_bufopen accept qsb as input for write operation. It
will make the API more logical:
1.If you create the QEMUSizedBuffer yourself, you need to
  free it by using qsb_free() but not depends on other API
  like qemu_fclose.
2.allow qemu_bufopen() accept QEMUSizedBuffer as input for
  write operation, otherwise, it will be a little strange
  for this API won't accept the second parameter.

This brings API change, since there are only 3
users of this API currently, this change only impact the
first one which will be fixed in patch 2 of this patchset,
so I think it is safe to do this change.

1     70  tests/test-vmstate.c <<open_mem_file_read>>
            return qemu_bufopen("r", qsb);
2    404  tests/test-vmstate.c <<test_save_noskip>>
            QEMUFile *fsave = qemu_bufopen("w", NULL);
3    424  tests/test-vmstate.c <<test_save_skip>>
            QEMUFile *fsave = qemu_bufopen("w", NULL);

Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com>
Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
Cc: Juan Quintela <quintela@redhat.com>
Cc: Amit Shah <amit.shah@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Amit Shah <amit.shah@redhat.com>
migration/qemu-file-buf.c