OSDN Git Service

change semantics of ldisc ->compat_ioctl()
authorAl Viro <viro@zeniv.linux.org.uk>
Fri, 14 Sep 2018 02:12:15 +0000 (22:12 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Sat, 13 Oct 2018 04:50:53 +0000 (00:50 -0400)
commitf0193d3ea73b966b5dbfa272c8228d743b8856ef
treec882a171c8706f274a7e09d8f7297c36ed750e34
parent7ee329655189f32f0c17e0bad60c23a69b003e9e
change semantics of ldisc ->compat_ioctl()

First of all, make it return int.  Returning long when native method
had never allowed that is ridiculous and inconvenient.

More importantly, change the caller; if ldisc ->compat_ioctl() is NULL
or returns -ENOIOCTLCMD, tty_compat_ioctl() will try to feed cmd and
compat_ptr(arg) to ldisc's native ->ioctl().

That simplifies ->compat_ioctl() instances quite a bit - they only
need to deal with ioctls that are neither generic tty ones (those
would get shunted off to tty_ioctl()) nor simple compat pointer ones.

Note that something like TCFLSH won't reach ->compat_ioctl(),
even if ldisc ->ioctl() does handle it - it will be recognized
earlier and passed to tty_ioctl() (and ultimately - ldisc ->ioctl()).

For many ldiscs it means that NULL ->compat_ioctl() does the
right thing.  Those where it won't serve (see e.g. n_r3964.c) are
also easily dealt with - we need to handle the numeric-argument
ioctls (calling the native instance) and, if such would exist,
the ioctls that need layout conversion, etc.

All in-tree ldiscs dealt with.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
drivers/bluetooth/hci_ldisc.c
drivers/input/serio/serport.c
drivers/net/hamradio/6pack.c
drivers/net/hamradio/mkiss.c
drivers/net/slip/slip.c
drivers/net/wan/x25_asy.c
drivers/tty/n_gsm.c
drivers/tty/n_r3964.c
drivers/tty/tty_io.c
include/linux/tty_ldisc.h
net/nfc/nci/uart.c