OSDN Git Service

crypto: don't optimize keccakf()
authorDmitry Vyukov <dvyukov@google.com>
Fri, 8 Jun 2018 09:53:41 +0000 (11:53 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 15 Jun 2018 15:06:48 +0000 (23:06 +0800)
commitf044a84e040b85cd609851ac88ae8b54b2cc0b75
tree29a62e2d18f271335ba95eed8b9863fb0684927c
parent6e88f01206edab0e5bc105d8f35fac10f4ee14c5
crypto: don't optimize keccakf()

keccakf() is the only function in kernel that uses __optimize() macro.
__optimize() breaks frame pointer unwinder as optimized code uses RBP,
and amusingly this always lead to degraded performance as gcc does not
inline across different optimizations levels, so keccakf() wasn't inlined
into its callers and keccakf_round() wasn't inlined into keccakf().

Drop __optimize() to resolve both problems.

Signed-off-by: Dmitry Vyukov <dvyukov@google.com>
Fixes: 83dee2ce1ae7 ("crypto: sha3-generic - rewrite KECCAK transform to help the compiler optimize")
Reported-by: syzbot+37035ccfa9a0a017ffcf@syzkaller.appspotmail.com
Reported-by: syzbot+e073e4740cfbb3ae200b@syzkaller.appspotmail.com
Cc: linux-crypto@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/sha3_generic.c