OSDN Git Service

selftests/bpf: Do not use sign-file as testcase
authorAlexey Gladkov <legion@kernel.org>
Wed, 17 May 2023 09:49:46 +0000 (11:49 +0200)
committerDaniel Borkmann <daniel@iogearbox.net>
Wed, 17 May 2023 13:43:32 +0000 (15:43 +0200)
commitf04a32b2c5b539e3c097cb5c7c1df12a8f4a0cf0
treecc9cadfad2ee178c2a016fdcf37ac86b6dddf663
parentcff36398bd4c7d322d424433db437f3c3391c491
selftests/bpf: Do not use sign-file as testcase

The sign-file utility (from scripts/) is used in prog_tests/verify_pkcs7_sig.c,
but the utility should not be called as a test. Executing this utility produces
the following error:

  selftests: /linux/tools/testing/selftests/bpf: urandom_read
  ok 16 selftests: /linux/tools/testing/selftests/bpf: urandom_read

  selftests: /linux/tools/testing/selftests/bpf: sign-file
  not ok 17 selftests: /linux/tools/testing/selftests/bpf: sign-file # exit=2

Also, urandom_read is mistakenly used as a test. It does not lead to an error,
but should be moved over to TEST_GEN_FILES as well. The empty TEST_CUSTOM_PROGS
can then be removed.

Fixes: fc97590668ae ("selftests/bpf: Add test for bpf_verify_pkcs7_signature() kfunc")
Signed-off-by: Alexey Gladkov <legion@kernel.org>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Roberto Sassu <roberto.sassu@huawei.com>
Acked-by: Stanislav Fomichev <sdf@google.com>
Link: https://lore.kernel.org/bpf/ZEuWFk3QyML9y5QQ@example.org
Link: https://lore.kernel.org/bpf/88e3ab23029d726a2703adcf6af8356f7a2d3483.1684316821.git.legion@kernel.org
tools/testing/selftests/bpf/Makefile