OSDN Git Service

kconfig: qconf: do not limit the pop-up menu to the first row
authorMasahiro Yamada <masahiroy@kernel.org>
Fri, 7 Aug 2020 09:19:08 +0000 (18:19 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Aug 2020 08:31:04 +0000 (10:31 +0200)
commitf0a40332820b52fce33c2fe14eb647af02952f6d
tree483c727d99e0548379be457264a1c873f8b68f1a
parente9701d5dd61067d16010388e843b1cc7ab403753
kconfig: qconf: do not limit the pop-up menu to the first row

[ Upstream commit fa8de0a3bf3c02e6f00b7746e7e934db522cdda9 ]

If you right-click the first row in the option tree, the pop-up menu
shows up, but if you right-click the second row or below, the event
is ignored due to the following check:

  if (e->y() <= header()->geometry().bottom()) {

Perhaps, the intention was to show the pop-menu only when the tree
header was right-clicked, but this handler is not called in that case.

Since the origin of e->y() starts from the bottom of the header,
this check is odd.

Going forward, you can right-click anywhere in the tree to get the
pop-up menu.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
scripts/kconfig/qconf.cc