OSDN Git Service

batman-adv: Use kref_get for _batadv_update_route
authorSven Eckelmann <sven@narfation.org>
Sat, 5 Mar 2016 18:05:24 +0000 (19:05 +0100)
committerAntonio Quartulli <a@unstable.cc>
Tue, 10 May 2016 10:28:29 +0000 (18:28 +0800)
commitf0b94ebccd2b924237ca7a101da3db70c3a8f0f2
tree106e0a52eaeef4f4816542ed77566916cfe72d93
parent17a8691502c9d2d792cfea7253b17382279ffb3e
batman-adv: Use kref_get for _batadv_update_route

_batadv_update_route requires that the caller already has a valid reference
for neigh_node. It is therefore not possible that it has an reference
counter of 0 and was still given to this function

The kref_get function instead WARNs (with debug information) when the
reference counter would still be 0. This makes a bug in batman-adv better
visible because kref_get_unless_zero would have ignored this problem.

Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Antonio Quartulli <a@unstable.cc>
net/batman-adv/routing.c