OSDN Git Service

scsi: sd_zbc: Fix variable type and bogus comment
authorDamien Le Moal <damien.lemoal@wdc.com>
Tue, 3 Jul 2018 06:23:58 +0000 (15:23 +0900)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 11 Jul 2018 02:25:03 +0000 (22:25 -0400)
commitf13cff6c25bd8986627365346d123312ee7baa78
tree03d3cbe622b7ec73849fead5f0874e5828bdafc3
parent36eb8ff672faee83ccce60c191f0fef07c6adce6
scsi: sd_zbc: Fix variable type and bogus comment

Fix the description of sd_zbc_check_zone_size() to correctly explain that
the returned value is a number of device blocks, not bytes.  Additionally,
the 32 bits "ret" variable used in this function may truncate the 64 bits
zone_blocks variable value upon return. To fix this, change "ret" type to
s64.

Fixes: ccce20fc79 ("sd_zbc: Avoid that resetting a zone fails sporadically")
Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
Cc: Bart Van Assche <bart.vanassche@wdc.com>
Cc: stable@kernel.org
Reviewed-by: Hannes Reinecke <hare@suse.com>
Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/sd_zbc.c