OSDN Git Service

NTB: Fix UB/bug in ntb_mw_get_align()
authorSerge Semin <fancer.lancer@gmail.com>
Wed, 6 Dec 2017 14:31:54 +0000 (17:31 +0300)
committerJon Mason <jdmason@kudzu.us>
Mon, 29 Jan 2018 03:17:24 +0000 (22:17 -0500)
commitf1678a4c66a5c2cb43f744f7dc7e048d59690166
treeab3025b16f95c20f786e988c5eb93feef9f61b57
parent417cf39cfea9c680aa7c278c8d8a0ca879cacf0a
NTB: Fix UB/bug in ntb_mw_get_align()

Simple (1 << pidx) operation causes undefined behaviour when
pidx >= 32. It must be casted to u64 to match the actual return
value of ntb_link_is_up() method, so to have all the possible
peer indexes covered and to get rid of undefined behaviour.
Additionally there are special macros in "linux/bitops.h" to perform
the bit-set-shift operations, so it's recommended to have them used
for proper bit setting.

Signed-off-by: Serge Semin <fancer.lancer@gmail.com>
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
include/linux/ntb.h