OSDN Git Service

brcmfmac: always print error when PSM's watchdog fires
authorRafał Miłecki <rafal@milecki.pl>
Fri, 24 Feb 2017 16:32:46 +0000 (17:32 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Mon, 20 Mar 2017 17:13:37 +0000 (19:13 +0200)
commitf1ac3aa212af6dd0a36dc07a63f95f91be6f4935
tree8bb5cf4732a245a6ec97986ccc45770090889f90
parentf825f6ed20e37a20ad5feaf607acfb84bfdf9d99
brcmfmac: always print error when PSM's watchdog fires

So far we were attaching BRCMF_E_PSM_WATCHDOG event listener in
brcmf_debug_attach which gets compiled only with CONFIG_BRCMDBG. This
event means something went wrong and firmware / hardware usually can't
be expected to work (reliably).

Such a problem is significant for user experience so I believe we should
print an error unconditionally (even with debugging disabled). What can
be indeed optional is dumping bus memory as this is clearly part of
debugging process.

In the future we may also try to extend this listener by trying to
recover from the error or at least signal it to the cfg80211.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c
drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h