OSDN Git Service

usb: phy: phy-fsl-usb: Make structure fsl_otg_initdata constant
authorNishka Dasgupta <nishkadg.linux@gmail.com>
Mon, 19 Aug 2019 07:42:34 +0000 (13:12 +0530)
committerFelipe Balbi <felipe.balbi@linux.intel.com>
Wed, 28 Aug 2019 10:04:59 +0000 (13:04 +0300)
commitf1b19006f4c9e83c9e19c58102157ff1fdebca22
tree2511c9093de45a5dde22c3a12f9ae0e9f1ccd609
parentc33f141615c2850ab512f7dca654f8f0914ab9ab
usb: phy: phy-fsl-usb: Make structure fsl_otg_initdata constant

Static structure fsl_otg_initdata, of type fsl_otg_config, is used only
once, when the value of its field otg_port is assigned to another
variable. As fsl_otg_initdata.otg_port is of type u8, any changes to
its copy do not affect the original, and fsl_otg_initdata itself is
never modified. Hence make fsl_otg_initdata constant to protect it from
unintended modification.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
drivers/usb/phy/phy-fsl-usb.c