OSDN Git Service

ASoC: intel: bxt_da7219_max98357a: Replace GFP_ATOMIC with GFP_KERNEL in broxton_audi...
authorJia-Ju Bai <baijiaju1990@gmail.com>
Mon, 9 Apr 2018 10:46:21 +0000 (18:46 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 16 Apr 2018 10:53:38 +0000 (11:53 +0100)
commitf2126f6d4fedfee6065351da4bab6b89d0ba4d1d
tree50066d9fe2db7dd1f6da1781e57c90c7a2dd38f1
parent0ae91ec43c16c825d914d056e55ba77d06b600fd
ASoC: intel: bxt_da7219_max98357a: Replace GFP_ATOMIC with GFP_KERNEL in broxton_audio_probe

broxton_audio_probe() is never called in atomic context.
This function is only set as ".probe" in "struct platform_driver".

Despite never getting called from atomic context,
broxton_audio_probe() calls devm_kzalloc() with GFP_ATOMIC,
which waits busily for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
to avoid busy waiting and improve the possibility of sucessful allocation.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/boards/bxt_da7219_max98357a.c