OSDN Git Service

ACPI: s2idle: Log when enabling wakeup IRQ fails
authorSimon Gaiser <simon@invisiblethingslab.com>
Mon, 13 Mar 2023 14:47:10 +0000 (15:47 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 20 Mar 2023 17:29:51 +0000 (18:29 +0100)
commitf2cba54a7fbf971d87bcd4467797c62d551401d3
tree4486a714ca7b889d1c1754262f5bdfaf49782ac2
parente8d018dd0257f744ca50a729e3d042cf2ec9da65
ACPI: s2idle: Log when enabling wakeup IRQ fails

enable_irq_wake() can fail. Previously acpi_s2idle_prepare() silently
ignored it's return code. Based on [1] we should try to continue even in
case of an error, so just log a warning for now.

Discovered when trying to go into s2idle under Xen. This leads to a
system that can't be woken, since xen-pirq currently doesn't support
setting wakeup IRQs [2]. With this you get at least some helpful log
message if you have access to console messages.

Link: https://lore.kernel.org/linux-acpi/20230313125344.2893-1-simon@invisiblethingslab.com/
Link: https://lore.kernel.org/linux-acpi/CAJZ5v0jahjt58nP6P5+xRdtD_ndYPvq4ecMVz6nfGu9tf5iaUw@mail.gmail.com/
Link: https://lore.kernel.org/xen-devel/20230313134102.3157-1-simon@invisiblethingslab.com/
Signed-off-by: Simon Gaiser <simon@invisiblethingslab.com>
[ rjw: Adjust white space ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/sleep.c