OSDN Git Service

HID: usbhid: use irqsave() in USB's complete callback
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Tue, 19 Jun 2018 21:59:44 +0000 (23:59 +0200)
committerJiri Kosina <jkosina@suse.cz>
Mon, 25 Jun 2018 13:24:46 +0000 (15:24 +0200)
commitf49255e00c2e085b1467087d2dbb6b01d7042cc8
tree788ba8ee2e5541105ac48e523355d34a0a6ee7e8
parentdc9b8e85ed95cbe7e3ad0eabb5b48d617bbc365e
HID: usbhid: use irqsave() in USB's complete callback

The USB completion callback does not disable interrupts while acquiring
the ->lock. We want to remove the local_irq_disable() invocation from
__usb_hcd_giveback_urb() and therefore it is required for the callback
handler to disable the interrupts while acquiring the lock.
The callback may be invoked either in IRQ or BH context depending on the
USB host controller.
Use the _irqsave() variant of the locking primitives.

Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: linux-input@vger.kernel.org
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/usbhid/hid-core.c