OSDN Git Service

platform/x86: dell-wmi-sysman: Fix release_attributes_data() getting called twice...
authorHans de Goede <hdegoede@redhat.com>
Sun, 21 Mar 2021 11:58:58 +0000 (12:58 +0100)
committerHans de Goede <hdegoede@redhat.com>
Sun, 21 Mar 2021 16:41:24 +0000 (17:41 +0100)
commitf4c4e9ad1523a32a78f5caf68f1b346a30035481
treef02ce597065e6cfd7b5b1fa72f3a67789dc2dff2
parentcb1e50f2f0a26fd4a4b1bdf669f5814fa414577a
platform/x86: dell-wmi-sysman: Fix release_attributes_data() getting called twice on init_bios_attributes() failure

All calls of init_bios_attributes() will result in a
goto fail_create_group if they fail, which calls
release_attributes_data().

So there is no need to call release_attributes_data() from
init_bios_attributes() on failure itself.

Fixes: e8a60aa7404b ("platform/x86: Introduce support for Systems Management Driver over WMI for Dell Systems")
Cc: Divya Bharathi <Divya_Bharathi@dell.com>
Cc: Mario Limonciello <mario.limonciello@dell.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20210321115901.35072-5-hdegoede@redhat.com
drivers/platform/x86/dell/dell-wmi-sysman/sysman.c