OSDN Git Service

net: sched: fix memory leak in tcindex_partial_destroy_work
authorPavel Skripkin <paskripkin@gmail.com>
Sat, 17 Jul 2021 11:29:33 +0000 (14:29 +0300)
committerDavid S. Miller <davem@davemloft.net>
Sun, 18 Jul 2021 16:45:46 +0000 (09:45 -0700)
commitf5051bcece50140abd1a11a2d36dc3ec5484fc32
tree291b135727b8f92bd8436405c6f73305edd91092
parenta17ad0961706244dce48ec941f7e476a38c0e727
net: sched: fix memory leak in tcindex_partial_destroy_work

Syzbot reported memory leak in tcindex_set_parms(). The problem was in
non-freed perfect hash in tcindex_partial_destroy_work().

In tcindex_set_parms() new tcindex_data is allocated and some fields from
old one are copied to new one, but not the perfect hash. Since
tcindex_partial_destroy_work() is the destroy function for old
tcindex_data, we need to free perfect hash to avoid memory leak.

Reported-and-tested-by: syzbot+f0bbb2287b8993d4fa74@syzkaller.appspotmail.com
Fixes: 331b72922c5f ("net: sched: RCU cls_tcindex")
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/cls_tcindex.c