OSDN Git Service

iommu/arm-smmu-v3: Don't free page table ops twice
authorJean-Philippe Brucker <jean-philippe.brucker@arm.com>
Thu, 14 Dec 2017 11:03:01 +0000 (11:03 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Jan 2018 08:35:25 +0000 (09:35 +0100)
commitf511ba8a5084687a354d18ac1ed8f04c197de63e
tree6ea9ea878113ecc34d657ed52fbd8eecf65370fb
parent745a0d9c1a8e6533f9707ffc2809e1c6198c29a7
iommu/arm-smmu-v3: Don't free page table ops twice

commit 57d72e159b60456c8bb281736c02ddd3164037aa upstream.

Kasan reports a double free when finalise_stage_fn fails: the io_pgtable
ops are freed by arm_smmu_domain_finalise and then again by
arm_smmu_domain_free. Prevent this by leaving pgtbl_ops empty on failure.

Fixes: 48ec83bcbcf5 ("iommu/arm-smmu: Add initial driver support for ARM SMMUv3 devices")
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/iommu/arm-smmu-v3.c