OSDN Git Service

selftests: router_bridge_vlan: Set vlan_default_pvid 0 on the bridge
authorPetr Machata <petrm@nvidia.com>
Fri, 2 Jun 2023 16:20:12 +0000 (18:20 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 5 Jun 2023 10:29:49 +0000 (11:29 +0100)
commitf5136877f421f298423e595fdf6a00e4e4c52706
tree65052bc46be6de1b1c66b5e255470645dfafb383
parent812de4dfab98640ebf0fd443b326c04724bf7eb0
selftests: router_bridge_vlan: Set vlan_default_pvid 0 on the bridge

When everything is configured, VLAN membership on the bridge in this
selftest are as follows:

    # bridge vlan show
    port              vlan-id
    swp2              1 PVID Egress Untagged
                      555
    br1               1 Egress Untagged
                      555 PVID Egress Untagged

Note that it is possible for untagged traffic to just flow through as VLAN
1, instead of using VLAN 555 as intended by the test. This configuration
seems too close to "works by accident", and it would be better to just shut
out VLAN 1 altogether.

To that end, configure vlan_default_pvid of 0:

    # bridge vlan show
    port              vlan-id
    swp2              555
    br1               555 PVID Egress Untagged

Signed-off-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: Amit Cohen <amcohen@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
tools/testing/selftests/net/forwarding/router_bridge_vlan.sh