OSDN Git Service

tcp: use a smaller percpu_counter batch size for sk_alloc
authorWei Wang <weiwan@google.com>
Tue, 2 Feb 2021 19:34:08 +0000 (11:34 -0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 4 Feb 2021 02:43:17 +0000 (18:43 -0800)
commitf5a5589c72509abaeb705123b64e7f5a078becf0
tree93de7e2e315b70f7d34a60b7b5b6cc0f56f8be1b
parent6fd5eeee1f107e2fb805609779994e3526de184f
tcp: use a smaller percpu_counter batch size for sk_alloc

Currently, a percpu_counter with the default batch size (2*nr_cpus) is
used to record the total # of active sockets per protocol. This means
sk_sockets_allocated_read_positive() could be off by +/-2*(nr_cpus^2).
This under/over-estimation could lead to wrong memory suppression
conditions in __sk_raise_mem_allocated().
Fix this by using a more reasonable fixed batch size of 16.

See related commit cf86a086a180 ("net/dst: use a smaller percpu_counter
batch for dst entries accounting") that addresses a similar issue.

Signed-off-by: Wei Wang <weiwan@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Soheil Hassas Yeganeh <soheil@google.com>
Link: https://lore.kernel.org/r/20210202193408.1171634-1-weiwan@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/net/sock.h