OSDN Git Service

vhost-net: fix use-after-free in vhost_net_flush
authorMichael S. Tsirkin <mst@redhat.com>
Tue, 25 Jun 2013 14:29:46 +0000 (17:29 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 28 Jul 2013 23:29:57 +0000 (16:29 -0700)
commitf5ce1d2513b74d4603769ed99636dc52144f02c4
tree3182bebad76864a8505b0df755dce840de48dd24
parent2b0e8a4ff83fd85afe5d0b84a2e1c6faa5fa56b8
vhost-net: fix use-after-free in vhost_net_flush

[ Upstream commit c38e39c378f46f00ce922dd40a91043a9925c28d ]

vhost_net_ubuf_put_and_wait has a confusing name:
it will actually also free it's argument.
Thus since commit 1280c27f8e29acf4af2da914e80ec27c3dbd5c01
    "vhost-net: flush outstanding DMAs on memory change"
vhost_net_flush tries to use the argument after passing it
to vhost_net_ubuf_put_and_wait, this results
in use after free.
To fix, don't free the argument in vhost_net_ubuf_put_and_wait,
add an new API for callers that want to free ubufs.

Acked-by: Asias He <asias@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/vhost/net.c