OSDN Git Service

drm/i915: Set best_encoder field of connector_state also when disabling
authorAnder Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Tue, 31 Mar 2015 08:35:00 +0000 (11:35 +0300)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 1 Apr 2015 12:14:58 +0000 (14:14 +0200)
commitf61cccf3e9a4f7deae633b6c073a6e40ef8e86f3
treed338888092c5503d3d3b8b4fd25b16510be16d05
parent88ac7939d2a6cb67e338e72cf6aaff2ae526b026
drm/i915: Set best_encoder field of connector_state also when disabling

The best_encoder field of connector_state wasn't properly set when a
connector was being disabled, leading to an incosistent atomic state.

For now, this doesn't cause anything to blow up, because everywhere
we're using connector_state->best_encoder there is a check for
connector_state->crtc which is properly initialized. I reached the issue
while testing some patches I haven't sent out yet, that remove the usage
of intel_connector->new_encoder from check_digital_port_conflicts(). In
that case, it would be possible to trigger the converted version of the
WARN in that function.

Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
[danvet: Add commit message augmentation Ander supplied.]
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_display.c