OSDN Git Service

can: hi311x: fix a signedness bug in hi3110_cmd()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 29 Jul 2021 14:12:46 +0000 (17:12 +0300)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Fri, 30 Jul 2021 06:45:03 +0000 (08:45 +0200)
commitf6b3c7848e66e9046c8a79a5b88fd03461cc252b
tree1af3e7913b1551225add44bed851b59a395b4ad8
parent8a7b46fa7902a3d36ce44a64f4d66586d66206ea
can: hi311x: fix a signedness bug in hi3110_cmd()

The hi3110_cmd() is supposed to return zero on success and negative
error codes on failure, but it was accidentally declared as a u8 when
it needs to be an int type.

Fixes: 57e83fb9b746 ("can: hi311x: Add Holt HI-311x CAN driver")
Link: https://lore.kernel.org/r/20210729141246.GA1267@kili
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/spi/hi311x.c