OSDN Git Service

ALSA: pcm: Fix mutex unbalance in OSS emulation ioctls
authorTakashi Iwai <tiwai@suse.de>
Tue, 27 Mar 2018 12:32:23 +0000 (14:32 +0200)
committerTakashi Iwai <tiwai@suse.de>
Tue, 27 Mar 2018 14:20:02 +0000 (16:20 +0200)
commitf6d297df4dd47ef949540e4a201230d0c5308325
treea270d39499d36075969c0a709a1a00a0d8d9d966
parent306a4f3ca7f3c7dfa473ebd19d66e40e59d99734
ALSA: pcm: Fix mutex unbalance in OSS emulation ioctls

The previous fix 40cab6e88cb0 ("ALSA: pcm: Return -EBUSY for OSS
ioctls changing busy streams") introduced some mutex unbalance; the
check of runtime->oss.rw_ref was inserted in a wrong place after the
mutex lock.

This patch fixes the inconsistency by rewriting with the helper
functions to lock/unlock parameters with the stream check.

Fixes: 40cab6e88cb0 ("ALSA: pcm: Return -EBUSY for OSS ioctls changing busy streams")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/oss/pcm_oss.c