OSDN Git Service

phy: rockchip-usb: add missing of_node_put
authorJulia Lawall <Julia.Lawall@lip6.fr>
Mon, 16 Nov 2015 11:33:17 +0000 (12:33 +0100)
committerKishon Vijay Abraham I <kishon@ti.com>
Thu, 3 Dec 2015 06:58:23 +0000 (12:28 +0530)
commitf6f31af81c77087c8884f5dc1ab91b029cd11842
tree198a6c56602dd3ec9c8690e9eecfa1b2408ec2bd
parentd0ca576af2120e23f2433041bf0865798e02c547
phy: rockchip-usb: add missing of_node_put

for_each_available_child_of_node performs an of_node_get on each iteration,
so a return from the middle of the loop requires an of_node_put.

A simplified version of the semantic patch that finds this problem is as
follows (http://coccinelle.lip6.fr):

// <smpl>
@@
expression root,e;
local idexpression child;
@@

 for_each_available_child_of_node(root, child) {
   ... when != of_node_put(child)
       when != e = child
(
   return child;
|
*  return ...;
)
   ...
 }
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Tested-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
drivers/phy/phy-rockchip-usb.c