OSDN Git Service

regulator: wm831x isink: Fix notifier mutex lock warning
authorSteve Twiss <stwiss.opensource@diasemi.com>
Tue, 26 Feb 2019 15:51:28 +0000 (15:51 +0000)
committerMark Brown <broonie@kernel.org>
Wed, 13 Mar 2019 15:13:01 +0000 (15:13 +0000)
commitf7a621728a6a23bfd2c6ac4d3e42e1303aefde0f
treec29177796187601c57fd3c2319403c36bd0ec9f0
parentae15c519a6b97fff087cf69502bdf8fc8892f4be
regulator: wm831x isink: Fix notifier mutex lock warning

The mutex for the regulator_dev must be controlled by the caller of
the regulator_notifier_call_chain(), as described in the comment
for that function.

Failure to mutex lock and unlock surrounding the notifier call results
in a kernel WARN_ON_ONCE() which will dump a backtrace for the
regulator_notifier_call_chain() when that function call is first made.
The mutex can be controlled using the regulator_lock/unlock() API.

Fixes: d4d6b722e780 ("regulator: Add WM831x ISINK support")
Suggested-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com>
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/wm831x-isink.c