OSDN Git Service

drm/i915/ehl: Don't program PHY_MISC on EHL PHY C
authorMatt Roper <matthew.d.roper@intel.com>
Wed, 26 Jun 2019 00:03:50 +0000 (17:03 -0700)
committerMatt Roper <matthew.d.roper@intel.com>
Mon, 1 Jul 2019 15:28:15 +0000 (08:28 -0700)
commitf80c9a9a04d3fa8231d2477f6a2c8b66a84ab41b
tree3fab9672879410ccbf8e1a584e35863d4e85e173
parent0e933162b0420b5258c34da719ac65269e4dbc49
drm/i915/ehl: Don't program PHY_MISC on EHL PHY C

Although EHL added a third combo PHY, no PHY_MISC register was added for
PHY C.  The bspec indicates that there's no need to program the "DE to
IO Comp Pwr Down" setting for this PHY that we usually need to set in
PHY_MISC.

v2:
 - Add IS_ELKHARTLAKE() guards since future platforms that have a PHY C
   are likely to reinstate the PHY_MISC register.  (Jose)
 - Use goto's to skip PHY_MISC programming & minimize code deltas. (Jose)

Bspec: 33148
Cc: José Roberto de Souza <jose.souza@intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190626000352.31926-4-matthew.d.roper@intel.com
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
drivers/gpu/drm/i915/display/intel_combo_phy.c