OSDN Git Service

Remove timing jitter during startup of audio
authorGlenn Kasten <gkasten@google.com>
Tue, 23 Apr 2013 19:39:37 +0000 (12:39 -0700)
committerGlenn Kasten <gkasten@google.com>
Tue, 23 Apr 2013 21:18:18 +0000 (14:18 -0700)
commitf8197a6a9d9363cb52bb8a2c15c0e5a52064355e
treeefad34614c9d7e77ed830768279005004376bbb2
parent1e25b79b28e578c43607faf100dcaf4cf068f05a
Remove timing jitter during startup of audio

This fixes a regression introduced recently, that increased timing jitter
during the startup of the FastMixer and AudioTrack callback threads.

The regression was to make requestPriority() asynchronous as a way to
avoid an apparent priority inversion in system_server.  This means that
the target thread could run briefly with the initial priority, before
the new priority takes effect.

This change removes the startup jitter for FastMixer, by making the
requestPriority() synchronous again for that case.  It doesn't matter
that this restores the priority inversion involving normal mixer thread,
because it happens during startup of both threads.

The change also removes the startup jitter for the AudioTrack callback
thread, by having the target thread check whether the requestPriority()
has completed yet.  If not, the target thread blocks with a timeout
until the priority boost finishes.

Finally, we now log an error message if the expected priority boost
doesn't happen.

Bug: 8698989
Change-Id: Id590e9a274b70ec1ba85b44a585ee37a22e41cbc
include/media/AudioTrack.h
media/libmedia/AudioTrack.cpp
services/audioflinger/FastMixer.cpp
services/audioflinger/ISchedulingPolicyService.cpp
services/audioflinger/ISchedulingPolicyService.h
services/audioflinger/SchedulingPolicyService.cpp
services/audioflinger/SchedulingPolicyService.h
services/audioflinger/Threads.cpp