OSDN Git Service

kthread: Simplify kthread_park() completion
authorPeter Zijlstra <peterz@infradead.org>
Thu, 7 Jun 2018 08:55:56 +0000 (10:55 +0200)
committerIngo Molnar <mingo@kernel.org>
Tue, 3 Jul 2018 07:20:44 +0000 (09:20 +0200)
commitf83ee19be4272564ad592ef90145db7295229490
tree181bd1628e2b233cd9e3b44ac6e608c24b7f34b4
parent167a88677b05d6a810f23b871cfb2b5db1808e60
kthread: Simplify kthread_park() completion

Oleg explains the reason we could hit park+park is that
smpboot_update_cpumask_percpu_thread()'s

  for_each_cpu_and(cpu, &tmp, cpu_online_mask)
smpboot_park_kthread();

turns into:

  for ((cpu) = 0; (cpu) < 1; (cpu)++, (void)mask, (void)and)
smpboot_park_kthread();

on UP, ignoring the mask. But since we just completely removed that
function, this is no longer relevant.

So revert commit:

  b1f5b378e126 ("kthread: Allow kthread_park() on a parked kthread")

Suggested-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/kthread.c