OSDN Git Service

target-arm: Raw CPSR writes should skip checks and bank switching
authorPeter Maydell <peter.maydell@linaro.org>
Tue, 23 Feb 2016 15:36:43 +0000 (15:36 +0000)
committerPeter Maydell <peter.maydell@linaro.org>
Fri, 26 Feb 2016 15:09:41 +0000 (15:09 +0000)
commitf8c88bbcda76d5674e4bb125471371b41d330df8
tree94a6ea0437de3b0629eba23dd6dde4e0e38a743c
parent50866ba5a2cfe922aaf3edb79f6eac5b0653477a
target-arm: Raw CPSR writes should skip checks and bank switching

Raw CPSR writes should skip the architectural checks for whether
we're allowed to set the A or F bits and should also not do
the switching of register banks if the mode changes. Handle
this inside cpsr_write(), which allows us to drop the "manually
set the mode bits to avoid the bank switch" code from all the
callsites which are using CPSRWriteRaw.

This fixes a bug in 32-bit KVM handling where we had forgotten
the "manually set the mode bits" part and could thus potentially
trash the register state if the mode from the last exit to userspace
differed from the mode on this exit.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Sergey Fedorov <serge.fdrv@gmail.com>
Message-id: 1455556977-3644-4-git-send-email-peter.maydell@linaro.org
target-arm/helper.c
target-arm/kvm64.c
target-arm/machine.c
target-arm/op_helper.c