OSDN Git Service

wireless: iwlwifi: Fix a double free in iwl_txq_dyn_alloc_dma
authorLv Yunlong <lyl2019@mail.ustc.edu.cn>
Sat, 3 Apr 2021 05:47:55 +0000 (22:47 -0700)
committerLuca Coelho <luciano.coelho@intel.com>
Tue, 7 Dec 2021 11:10:10 +0000 (13:10 +0200)
commitf973795a8d19cbf3d03807704eb7c6ff65788d5a
tree80e0c249bc7db4e8df1803a279c3013641a8f477
parent46c7b05a4f91f425d429bbe152c0185e9f8a5d18
wireless: iwlwifi: Fix a double free in iwl_txq_dyn_alloc_dma

In iwl_txq_dyn_alloc_dma, txq->tfds is freed at first time by:
iwl_txq_alloc()->goto err_free_tfds->dma_free_coherent(). But
it forgot to set txq->tfds to NULL.

Then the txq->tfds is freed again in iwl_txq_dyn_alloc_dma by:
goto error->iwl_txq_gen2_free_memory()->dma_free_coherent().

My patch sets txq->tfds to NULL after the first free to avoid the
double free.

Fixes: 0cd1ad2d7fd41 ("iwlwifi: move all bus-independent TX functions to common code")
Signed-off-by: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
Link: https://lore.kernel.org/r/20210403054755.4781-1-lyl2019@mail.ustc.edu.cn
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/intel/iwlwifi/queue/tx.c