OSDN Git Service

migration: fix use-after-free of to_dst_file
authorVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Sat, 25 Feb 2017 19:31:55 +0000 (22:31 +0300)
committerDr. David Alan Gilbert <dgilbert@redhat.com>
Tue, 28 Feb 2017 11:30:23 +0000 (11:30 +0000)
commitf9c8caa04f7f2bed12dc5a4d7e92a59fe6677b37
tree1a783b2de80762744924e7e74e18a2bce393b30b
parent5f9412bbac3a6906b2277d6b8aea02bc12a8464d
migration: fix use-after-free of to_dst_file

hmp_savevm calls qemu_savevm_state(f), which sets to_dst_file=f in
global migration state. Then hmp_savevm closes f (g_free called).

Next access to to_dst_file in migration state (for example,
qmp_migrate_set_speed) will use it after it was freed.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20170225193155.447462-5-vsementsov@virtuozzo.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
migration/savevm.c