OSDN Git Service

crypto: x86/chacha - avoid sleeping under kernel_fpu_begin()
authorEric Biggers <ebiggers@google.com>
Sat, 15 Dec 2018 20:40:17 +0000 (12:40 -0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Sun, 23 Dec 2018 03:52:44 +0000 (11:52 +0800)
commitf9c9bdb5131eee60dc3b92e5126d4c0e291703e2
tree880c29e660d78a9cd191af522a0068a9c62f7731
parentc9613335bf4fe259a654aa0e9701f0c4cddc12ba
crypto: x86/chacha - avoid sleeping under kernel_fpu_begin()

Passing atomic=true to skcipher_walk_virt() only makes the later
skcipher_walk_done() calls use atomic memory allocations, not
skcipher_walk_virt() itself.  Thus, we have to move it outside of the
preemption-disabled region (kernel_fpu_begin()/kernel_fpu_end()).

(skcipher_walk_virt() only allocates memory for certain layouts of the
input scatterlist, hence why I didn't notice this earlier...)

Reported-by: syzbot+9bf843c33f782d73ae7d@syzkaller.appspotmail.com
Fixes: 4af78261870a ("crypto: x86/chacha20 - add XChaCha20 support")
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
arch/x86/crypto/chacha_glue.c