OSDN Git Service

media: uvcvideo: Fix driver reference counting
authorPhilipp Zabel <philipp.zabel@gmail.com>
Mon, 21 May 2018 10:24:58 +0000 (06:24 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Mon, 28 May 2018 20:49:47 +0000 (16:49 -0400)
commitf9ffcb0a21e1fa8e64d09ed613d884e054ae8191
tree3056d7b1b874e007d756dd264691faba460530f1
parent6c0e931c740a7fbd4697d77d380310ba6e1d1acf
media: uvcvideo: Fix driver reference counting

kref_init initializes the reference count to 1, not 0. This additional
reference is never released since the conversion to reference counters.
As a result, uvc_delete is not called anymore when UVC cameras are
disconnected.
Fix this by adding an additional kref_put in uvc_disconnect and in the
probe error path. This also allows to remove the temporary additional
reference in uvc_unregister_video.

Fixes: 9d15cd958c17 ("media: uvcvideo: Convert from using an atomic variable to a reference count")

Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/usb/uvc/uvc_driver.c